[Modpack] Sea [0.4.2] [sea]

[galundrux]

I don't think they consider it a bug, the one who set out to "fix" this is aware of it and said it's this or nothing. The only light in the tunnel I can see is that sprites can be under water with no problems, the clams mob works fine. I did some experiments where I had coral spawn as mob sprite by editing the clams mod. This kinda works, but I haven't found a way to make sprites be stationary and not follow the camera, also the sprites parameter only creates one plane, and we'll need two. But people who can code the engine should be able to use that, they can make a "plantlike sprite" or something that behaves the way we need it to.

Without being a coder and really knowing what I'm talking about, it seems to me that the entire liquid system is kinda broken, or badly implemented. If something can exist in air, then why is it not behaving the same way in water? Below the surface we don't need there to be actual water, just something that tells the game "this is water" so it can apply the blue overlay and slow the movement and so on. It's only really where air and water collide that requires special treatment. I'm guessing it has something to do with how voxels work that is making this difficult. But wouldn't it be cool if both air and water was considered liquids of different density and it was only where they collide that required any calculations? That way we could make all kinds of new game mechanics, like gas. Imagine if the ground blocks of the mushroom biome for example emitted a gas (liquid going the opposite direction), tint the screen green or something, make you lose life, requires a gas mask type helmet to be crafted and worn in order to move around there safely. Or the ability to make gas grenades, or heavy fog in the morning in some biomes that would slow movement and limit visibility. Would be so many things we could do...

[Shara]

Not entirely happy with this as it makes it impossible to interact with the plants in any way

Have you checked what the new kelp plants are like in 5.0.0? I had the same frustration when first seeing that in game, so I added selection boxes for the kelp in MTG and made it so digging the kelp doesn't remove the node it's in. (What actually happens, since the kelp is the same node as the sand node it's in, is that the sand_with_kelp node gets replaced with a normal sand node when you dig it.)

The only thing you will actually lose is the ability to remove each part of the plant piece by piece, but with some tinkering I could probably recreate that affect as well. I'm pretty sure I could also make them grow. (I'm just not sure if I'd want to, due to the complexity).

I will eventually make a working version of the sea plants for 5.0.0 if no one beats me to it, but wasn't planning on doing it yet due to very limited time.

If you need it right now, I suggest looking at the kelp code to see how that works. It's a biggish chunk of code if you are a non-coder though.

[SteveGer]

Hey.

I like the Style of the Seastone and i want to use it. but:

- stonebricks are made by combining 4 stone-blocks in a square

Really? i need FOUR Seastone for ONE Seastone Brick? In this case i use better another Bricks. All other recipes for Bricks works in the same way:

{group:stone},{group:stone},
{group:stone},{group:stone},
,,

gives FOUR (Not ONE) of the {group:brick}

All other is stealing players Resources. Think about it, not all Servers are creative.

So Long
Steve

[scr267]

Is this mod still being maintained? I'm having issues with performance that I've isolated to the seaplants lua script.

Thank you

[redblade7]

Since the upgrade to v5 i have this occasional crash:

2019-03-29 16:01:36: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'seaglass' in callback node_on_punch(): (REMOVED)/bin/../games/minetest_game/mods/sea/seaglass/init.lua:332: attempt to call global 'nodeupdate' (a nil value)
2019-03-29 16:01:36: ERROR[Main]: stack traceback:
2019-03-29 16:01:36: ERROR[Main]: (REMOVED)/bin/../games/minetest_game/mods/sea/seaglass/init.lua:332: in function 'callback'
2019-03-29 16:01:36: ERROR[Main]: (REMOVED)/bin/../builtin/game/item.lua:511: in function <(REMOVED)/bin/../builtin/game/item.lua:504>

[texmex]

The nodeupdate function needs to be replaced with the newer check_for_falling function.

[redblade7]

The nodeupdate function needs to be replaced with the newer check_for_falling function.

Is this as easy as replacing all instances of "nodeupdate(pos)" with "check_for_falling(pos)" in seaglass/init.lua?

[texmex]

Pretty much, but consult the Lua API doc first.

[redblade7]

Pretty much, but consult the Lua API doc first.

I don't know Lua in detail, but after changing all the "nodeupdate(pos)" to "check_for_falling(pos)", after punching the seaglass I get the same crash, but with:

"attempt to call global 'check_for_falling' (a nil value)"

[texmex]

It’s minetest.check_for_falling.

[Topywo]

Recently this thread by Brian Gaucher drew my attention: https://forum.minetest.net/viewtopic.php?f=47&t=22360#p346430 I didn't work on this mod for more than 2 years.

It has never been a much used mod and there are people who don't like the solution I use for the airblocks (for one it seems to consume too much power/memory), my coding isn't the best (I never learned Lua and find the 'handles' difficult to grasp.).

That said, a few days ago I downloaded minetest. The sea-mod that was still in my dropbox. I also downloaded the latest unified dyes I had from there.

I got the thing started and found out the airblocks weren't removed anymore in this mod. So I looked up the 'water' registration to see what changed. I found it (some extra text before .png is needed). Almost one bug les, but 'stairs' have also been changed, because those still had a part of the air.

From then on I have been experimenting to mirror the way airblocks works (from the star everything no air, except the water surface), but that didnt work the way I wanted.

After that I started browsing through the mods in the seapack.

Only to the point part of this post :-p
I got the 'nodeupdate' error when hitting a glassblock. Also saw this function was depreciated and replaced by the 'checkforfalling', wich didn't seem logical for my mod. So first thing I tried was just deleting 'nodeupdate'
everywhere. To my surprise that worked. (Making me wonder why I needed that piece of code in the first place...)

After some more browsing I found out the unifieddyes mod had changed, so the coral didn't give me dye's anymore. I did find the latest working unifieddyes for the seamod in Vanessa's Gitlab. I also suspect Sokomine's bootspray mod doest work right now with the sea-modpack.

The (for me) new biomes and decorations look promising for the modpack, but I need to experiment with them. I'm not very happy with the shipwrecks-mod I made right now (Typing this I just realise I sometimes found two ships too close together and never found a submarine so far). On the other hand maybe schematics improved. I may also rework the whiteshell stuff. On hindsight the crafing and stuff look like a bit too much.

I like my glass, but those are only 5 colors iirc. I prefer more. (maybe I can integrate the lightblocks I once made for the Cash's World Server. I also saw there was some new coding for glass I have to learn to understand. And the coding (at least how I did it) is quite some work. I also need to integrate the new outer/inner stairs blocks. (also a lot of work).

Conclusion
I bet I will also find out about more broken stuff in the modpack and new coding/license/lay-out stuff. But one has to start somewhere and I started a few days ago. One thing I really would like to see in the Oceans are animals/fish, but I'm probably not capable programming those, nor designing them.

So expect at least a repaired and maybe an improved version of this mod, but not too soon.

[redblade7]

I got the 'nodeupdate' error when hitting a glassblock. Also saw this function was depreciated and replaced by the 'checkforfalling', wich didn't seem logical for my mod. So first thing I tried was just deleting 'nodeupdate'
everywhere. To my surprise that worked. (Making me wonder why I needed that piece of code in the first place...)

That did it, thank you!

Looking forward to your new version!