[open] swap_node = ...

[Festus1965]

[Solved] so far,
but have to check the starting with this issues, where in moretrees/cocos_palm.lua
what made me set this var wrong - and solved the crash there ...

edit: see issue 3015
got problems last night on
Minetest 5.1.0-dev-77cfc4f-dirty (Linux)
edit same then under 5.0.0-stable

Code: Select all

2019-03-22 06:34:25: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'mesecons' in callback environment_Step(): .../.minetest/mods/mesecons/mesecons_luacontroller/init.lua:155: attempt to call field 'swap_node' (a table value)
2019-03-22 06:34:25: ERROR[Main]: stack traceback:
2019-03-22 06:34:25: ERROR[Main]:    .../.minetest/mods/mesecons/mesecons_luacontroller/init.lua:155: in function 'set_port_states'
2019-03-22 06:34:25: ERROR[Main]:    .../.minetest/mods/mesecons/mesecons_luacontroller/init.lua:616: in function 'run_inner'
2019-03-22 06:34:25: ERROR[Main]:    .../.minetest/mods/mesecons/mesecons_luacontroller/init.lua:655: in function 'run'
2019-03-22 06:34:25: ERROR[Main]:    .../.minetest/mods/mesecons/mesecons_luacontroller/init.lua:684: in function <.../.minetest/mods/mesecons/mesecons_luacontroller/init.lua:680>
2019-03-22 06:34:25: ERROR[Main]:    .../thomas/.minetest/mods/mesecons/mesecons/actionqueue.lua:93: in function 'execute'
2019-03-22 06:34:25: ERROR[Main]:    .../thomas/.minetest/mods/mesecons/mesecons/actionqueue.lua:84: in function 'func'
2019-03-22 06:34:25: ERROR[Main]:    ...ocal/share/minetest/builtin/profiler/instrumentation.lua:106: in function <...ocal/share/minetest/builtin/profiler/instrumentation.lua:100>
2019-03-22 06:34:25: ERROR[Main]:    /usr/local/share/minetest/builtin/game/register.lua:419: in function </usr/local/share/minetest/builtin/game/register.lua:399>
2019-03-22 06:34:25: ERROR[Main]: stack traceback:

what goes back via mesecons, profiler to buildin/gamer ... where I am not changing things - only maybe via "git pull"

and after I gave there a
swap_node = {}
(later taken out of code again, as seam deeper reason) -> /usr/local/share/minetest/builtin/game/register.lua
then next one complain

Code: Select all

2019-03-22 06:35:08: ERROR[Server]: LuaEntity name "mobs_animal:pumba" not defined
2019-03-22 06:35:08: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moremesecons_adjustable_blinkyplant' in callback node_on_timer(): /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:250: attempt to call field 'swap_node' (a table value)
2019-03-22 06:35:08: ERROR[Main]: stack traceback:
2019-03-22 06:35:08: ERROR[Main]:    /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:250: in function 'flipstate'
2019-03-22 06:35:08: ERROR[Main]:    ...oremesecons/moremesecons_adjustable_blinkyplant/init.lua:16: in function <...oremesecons/moremesecons_adjustable_blinkyplant/init.lua:15>

meant at end
* moremesecons_adjustable_blinkyplant
* adjustable_blinkyplant
= false, to get server running

[Festus1965]

hmm with new build
Minetest 5.1.0-dev-38ea089-dirty (Linux)
and both blinkys = true it runs yet ...
* for start server, before it crashed just with start

but later crashed again (someone new joined)

Code: Select all

2019-03-22 08:31:02: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moremesecons_adjustable_blinkyplant' in callback node_on_timer(): /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:254: attempt to call field 'swap_node' (a table value)
2019-03-22 08:31:02: ERROR[Main]: stack traceback:
2019-03-22 08:31:02: ERROR[Main]:    /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:254: in function 'flipstate'
2019-03-22 08:31:02: ERROR[Main]:    ...oremesecons/moremesecons_adjustable_blinkyplant/init.lua:21: in function <...oremesecons/moremesecons_adjustable_blinkyplant/init.lua:20>
2019-03-22 08:31:32: [Main]: Using game specified by --gameid on the command line


at last again

Code: Select all

2019-03-22 09:15:32: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moremesecons_adjustable_blinkyplant' in callback node_on_timer(): /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:254: attempt to call field 'swap_node' (a table value)
2019-03-22 09:15:32: ERROR[Main]: stack traceback:
2019-03-22 09:15:32: ERROR[Main]:    /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:254: in function 'flipstate'
2019-03-22 09:15:32: ERROR[Main]:    ...oremesecons/moremesecons_adjustable_blinkyplant/init.lua:21: in function <...oremesecons/moremesecons_adjustable_blinkyplant/init.lua:20>


so both blinkys off now

[Festus1965]

even with replace mesesons and moremesecons new non touched code folders
same

Code: Select all

2019-03-22 09:42:56: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'mesecons_blinkyplant' in callback node_on_timer(): /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:250: attempt to call field 'swap_node' (a table value)
2019-03-22 09:42:56: ERROR[Main]: stack traceback:
2019-03-22 09:42:56: ERROR[Main]:    /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:250: in function 'flipstate'
2019-03-22 09:42:56: ERROR[Main]:    ...as/.minetest/mods/mesecons/mesecons_blinkyplant/init.lua:14: in function <...as/.minetest/mods/mesecons/mesecons_blinkyplant/init.lua:12>


[Festus1965]

and now here:

Code: Select all

2019-03-22 09:53:26: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback item_OnPlace(): ...l/share/minetest/games/minetest_game/mods/doors/init.lua:179: attempt to call field 'swap_node' (a table value)
2019-03-22 09:53:26: ERROR[Main]: stack traceback:
2019-03-22 09:53:26: ERROR[Main]:    ...l/share/minetest/games/minetest_game/mods/doors/init.lua:179: in function 'door_toggle'
2019-03-22 09:53:26: ERROR[Main]:    ...l/share/minetest/games/minetest_game/mods/doors/init.lua:376: in function 'on_rightclick'
2019-03-22 09:53:26: ERROR[Main]:    /usr/local/share/minetest/builtin/game/item.lua:423: in function </usr/local/share/minetest/builtin/game/item.lua:416>


[Festus1965]

also happen under 5.0.0-stable

Code: Select all

2019-03-22 12:00:28: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback item_OnPlace(): ...l/share/minetest/games/minetest_game/mods/doors/init.lua:179: attempt to call field 'swap_node' (a table value)
2019-03-22 12:00:28: ERROR[Main]: stack traceback:
2019-03-22 12:00:28: ERROR[Main]:    ...l/share/minetest/games/minetest_game/mods/doors/init.lua:179: in function 'door_toggle'
2019-03-22 12:00:28: ERROR[Main]:    ...l/share/minetest/games/minetest_game/mods/doors/init.lua:376: in function 'on_rightclick'
2019-03-22 12:00:28: ERROR[Main]:    /usr/local/share/minetest/builtin/game/item.lua:423: in function </usr/local/share/minetest/builtin/game/item.lua:416>

what mod, or location is "Runtime error from mod '' in callback item_OnPlace()"

[Festus1965]

* changed all mods, in mods to 2 day older saved version, as I have made a mistake as of include print luamem,
* remove and purge minetest-server, install, purge again ...
* recompile stable, with cmake, make install again ...
= same problem

now looking who or what would delete that /usr/local/share/minetest/* and reinstall all that ...
ah
* git clone --depth 1 https://github.com/minetest/minetest_game.git games/minetest_game
* cmake ...
* sudo make -j8 install
got

Code: Select all

...
-- Up-to-date: /usr/local/share/minetest/games//minetest_game/mods/doors
-- Installing: /usr/local/share/minetest/games//minetest_game/mods/doors/license.txt
-- Installing: /usr/local/share/minetest/games//minetest_game/mods/doors/README.txt
-- Installing: /usr/local/share/minetest/games//minetest_game/mods/doors/init.lua
-- Up-to-date: /usr/local/share/minetest/games//minetest_game/mods/doors/sounds
...

but = same, right click door = crash

[rubenwardy]

There's a mod problem here. Also, the line number in the first post doesn't match mesecons which implies that it's out of date, so I suggest updating the mod pack

Search for "swap_node" in all your mods and make sure none are assigning it
Maybe paste the output here.

You can do this by running this command: grep -rn "swap_node" ~/.minetest/mods/

[Festus1965]

... make sure none are assigning it ...

have to check the meaning of this part ...

taking from
* https://github.com/minetest-mods/mesecons "073c92d 6 days ago"
and
replaced inside .minetest/mods/ with this new one /mesecons
and took it, same with no complain

Code: Select all

[Mod] mesecons / mesecons (073c92d 20.03.2019) 0.4.x - loaded - end with 3503 KB

so ... check

and as soon i set a nearby adjustable_blinkyplant new time get

Code: Select all

2019-03-23 08:17:50: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moremesecons_adjustable_blinkyplant' in callback node_on_timer(): /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:250: attempt to call field 'swap_node' (a table value)
2019-03-23 08:17:50: ERROR[Main]: stack traceback:
2019-03-23 08:17:50: ERROR[Main]:    /home/thomas/.minetest/mods/mesecons/mesecons/util.lua:250: in function 'flipstate'
2019-03-23 08:17:50: ERROR[Main]:    ...oremesecons/moremesecons_adjustable_blinkyplant/init.lua:16: in function <...oremesecons/moremesecons_adjustable_blinkyplant/init.lua:15>


[rubenwardy]

I meant that it's weird that swap_node is a table, it should be a function. So I suspect that something is setting to it, like:

Code: Select all

minetest.swap_node = something


Seeing the results of grep could confirm it

[Festus1965]

I meant that it's weird that swap_node is a table, it should be a function.

ah, ok -

but funny also,
that day before this happened I was only on 2nd machine, and measuring lua memory consumption, and only set 3 more mods false at this server before went sleep ... so there was no code change explaining that this failure started in that night,

so if my mistake, but even that I did AFTER first crash, need to search for wrong "swap_node = {}" ?

[Festus1965]

don't need to send grep result,
could read it myself, and also remember now what I had to search for
found
in ./mods/moretrees/cocos_palm

Code: Select all

minetest.swap_node = {} -- until now, attempt to index a nil value, line 99 to 118

but this code I did IN after the failure with "swap_node" happened first time, as referring to unknown global ,...

ah, moment ...

[Festus1965]

running so far
tested
* adjustable_blinkyplant = no crash
* can use doors right_click = no crash
need to find cocos tree, as here it started all

thanks for the hint ! with grep, via search monkey i didn't find it

this was the reason, as crashed before

Code: Select all

elseif not moretrees.coconuts_regrow then
      -- Regrowing has been turned off. Make coconust grow instantly
      minetest.swap_node(pos, {name="moretrees:coconut_3"})
      return

and MADE me using the code above to get around here as crashed before.

[Festus1965]

one more, but I override it with new original untouched

Code: Select all

2019-03-23 15:08:10: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moretrees' in callback LuaABM::trigger(): attempt to index a nil value
2019-03-23 15:08:10: ERROR[Main]: stack traceback:
2019-03-23 15:08:10: ERROR[Main]:    [C]: in function 'swap_node'
2019-03-23 15:08:10: ERROR[Main]:    /home/thomas/.minetest/mods/moretrees/init.lua:251: in function 'grow_jungletree'
2019-03-23 15:08:10: ERROR[Main]:    (load):1: in main chunk
2019-03-23 15:08:10: ERROR[Main]:    /home/thomas/.minetest/mods/biome_lib/init.lua:642: in function 'replace_object'
2019-03-23 15:08:10: ERROR[Main]:    /home/thomas/.minetest/mods/biome_lib/init.lua:616: in function </home/thomas/.minetest/mods/biome_lib/init.lua:590>


no crash at start, but when "used"

[rubenwardy]

in ./mods/moretrees/cocos_palm

Code: Select all

minetest.swap_node = {} -- until now, attempt to index a nil value, line 99 to 118

but this code I did IN after the failure with "swap_node" happened first time, as referring to unknown global ,...

Remove that line completely, it's not correct at all.

The error about being unable to index nil is due to the position or node being nil, more likely the former

[Festus1965]

in ./mods/moretrees/cocos_palm

That was the one I deleted in the morning, after I remember one missing, but you gave better search tool, and it should not have been in the grep result.
After this removing the crash happened with the last post about in moretrees/grow_jungletree when gamer Bron came in, didn't happen jet again, but sure I didn't change anything until now as no glue.

[Festus1965]

again!

Code: Select all

2019-03-24 19:48:39: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moretrees' in callback node_on_timer(): attempt to index a nil value
2019-03-24 19:48:39: ERROR[Main]: stack traceback:
2019-03-24 19:48:39: ERROR[Main]:    [C]: in function 'swap_node'
2019-03-24 19:48:39: ERROR[Main]:    /home/thomas/.minetest/mods/moretrees/cocos_palm.lua:118: in function </home/thomas/.minetest/mods/moretrees/cocos_palm.lua:99>

sofar I search,cant find any wrong declaration from me like before "swap_node = nil", but will search again

from line 99 - 120

Code: Select all

local coconut_growfn = function(pos, elapsed)
   local node = minetest.get_node(pos)
   local delay = moretrees.coconut_grow_interval
   if not node then
      return
   elseif not moretrees.coconuts_regrow then
      -- Regrowing has been turned off. Make coconust grow instantly
      minetest.swap_node(pos, {name="moretrees:coconut_3"})
      return
   elseif node.name == "moretrees:coconut_3" then
      -- Drop coconuts (i.e. remove them), so that new coconuts can grow.
      -- Coconuts will drop as items with a small chance
      if math.random(coconut_drop_ichance) == 1 then
         if moretrees.coconut_item_drop_ichance > 0 and math.random(moretrees.coconut_item_drop_ichance) == 1 then
            local items = minetest.get_node_drops(minetest.get_node(pos).name)
            for _, itemname in pairs(items) do
               minetest.add_item(pos, itemname)
            end
         end
         minetest.swap_node(pos, biome_lib.air)
      end
   else

oh found some with "grep -rn "swap_node" ~/.minetest/mods/"
* /mods/homedecor_modpack/homedecor/handlers/furnaces.lua:5:local function swap_node(pos, name)
as in the original https://gitlab.com/VanessaE/homedecor_modpack/blob/master/homedecor/handlers/furnaces.lua#L5

* /mods/pipeworks/compat-furnaces.lua:120:local function swap_node(pos, name)
as in the original https://gitlab.com/VanessaE/pipeworks/blob/master/compat-furnaces.lua#L120

I took local out and test until tomorrow, also reactivate then cocos ...

[Festus1965]

but

Code: Select all

2019-03-24 20:59:25: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moretrees' in callback LuaABM::trigger(): attempt to index a nil value
2019-03-24 20:59:25: ERROR[Main]: stack traceback:
2019-03-24 20:59:25: ERROR[Main]:    [C]: in function 'swap_node'
2019-03-24 20:59:25: ERROR[Main]:    /home/thomas/.minetest/mods/moretrees/init.lua:186: in function 'grow_birch'
2019-03-24 20:59:25: ERROR[Main]:    (load):1: in main chunk
2019-03-24 20:59:25: ERROR[Main]:    /home/thomas/.minetest/mods/biome_lib/init.lua:642: in function 'replace_object'
2019-03-24 20:59:25: ERROR[Main]:    /home/thomas/.minetest/mods/biome_lib/init.lua:616: in function 'func'
2019-03-24 20:59:25: ERROR[Main]:    ...ocal/share/minetest/builtin/profiler/instrumentation.lua:106: in function <...ocal/share/minetest/builtin/profiler/instrumentation.lua:100>


but "attempt to index a nil value" indicates for me some like "swap_node = nil" still somewhere there

grep -rn "function swap_node" ~/.minetest/mods/ :

Code: Select all

grep -rn "function swap_node" ~/.minetest/mods/
/home/thomas/.minetest/mods/pipeworks/compat-furnaces.lua:120:function swap_node(pos, name)
/home/thomas/.minetest/mods/homedecor_modpack/homedecor/handlers/furnaces.lua:5:function swap_node(pos, name)

thoses which had local in front, i took off

grep -rn "swap_node = nil" ~/.minetest/mods/ - nothing
grep -rn "swap_node = {}" ~/.minetest/mods/ - nothing
grep -rn "swap_node = " ~/.minetest/mods/

Code: Select all

/home/thomas/.minetest/mods/locks/shared_locked_furnace.lua:320:locks.hacky_swap_node = function(pos,name)
/home/thomas/.minetest/mods/WorldEdit/worldedit/visualization.lua:22:   local get_node, get_meta, swap_node = minetest.get_node,
/home/thomas/.minetest/mods/WorldEdit/worldedit/visualization.lua:60:   local get_node, get_meta, swap_node = minetest.get_node,
/home/thomas/.minetest/mods/WorldEdit/worldedit/visualization.lua:82:   local get_node, get_meta, swap_node = minetest.get_node,
/home/thomas/.minetest/mods/WorldEdit/worldedit/visualization.lua:118:   local get_node, get_meta, swap_node = minetest.get_node,
/home/thomas/.minetest/mods/WorldEdit/worldedit/manipulations.lua:561:   local set_node, get_node, get_meta, swap_node = minetest.set_node,


[Festus1965]

mhh no idea where it is set nil

Code: Select all

2019-03-25 06:55:07: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moretrees' in callback node_on_timer(): attempt to index a nil value
2019-03-25 06:55:07: ERROR[Main]: stack traceback:
2019-03-25 06:55:07: ERROR[Main]:    [C]: in function 'swap_node'
2019-03-25 06:55:07: ERROR[Main]:    /home/thomas/.minetest/mods/moretrees/cocos_palm.lua:118: in function </home/thomas/.minetest/mods/moretrees/cocos_palm.lua:99>


extend the search to
* /usr/local/share/minetest/games/minimal/mods/default/init.lua:1423:function swap_node(pos,name)
* /usr/local/share/minetest/games/minetest_game/mods/default/furnace.lua:90:local function swap_node(pos, name)

grep -rn "swap_node" ~/.minetest/worlds/CelinesWildesThailand/worldmods/ - nothing

[rubenwardy]

It's not set to nil, it's given nil as one of the parameters

[Festus1965]

It's not set to nil, it's given nil as one of the parameters

Code: Select all

attempt to index a nil value

gibe me a hint where to search next ... otherwise I fear have to set all new ...

[Festus1965]

Code: Select all

2019-03-25 13:37:02: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'moretrees' in callback LuaABM::trigger(): attempt to index a nil value
2019-03-25 13:37:02: ERROR[Main]: stack traceback:
2019-03-25 13:37:02: ERROR[Main]:    [C]: in function 'swap_node'
2019-03-25 13:37:02: ERROR[Main]:    /home/thomas/.minetest/mods/moretrees/init.lua:186: in function 'grow_birch'
2019-03-25 13:37:02: ERROR[Main]:    (load):1: in main chunk
2019-03-25 13:37:02: ERROR[Main]:    /home/thomas/.minetest/mods/biome_lib/init.lua:642: in function 'replace_object'
2019-03-25 13:37:02: ERROR[Main]:    /home/thomas/.minetest/mods/biome_lib/init.lua:616: in function </home/thomas/.minetest/mods/biome_lib/init.lua:590>