valley mapgen mod crashes minetest 5.0

[JCB]

Hello all,

recently I have been having minetest 5.0 crash. This is becoming more frequent and it looks to be tied to the valley_mapgen mod. When I disable it, I am not experiencing crashes.

Looking in the debug log, I see : 2019-03-31 06:47:54: WARNING[Main]: Client side scripting is disabled by client. just prior to the crash (search the web did not turn up a search for the Warning and valley_mapgen)

Not sure if this is the issue (or is there is a better place to get logs (/var/log/minetest logs don't show much) ) I can post more logs if I get some direction where to locate them. (Ubuntu 18.014)

Thoughts on troubleshooting the issue? I can disable the mod, however I am left with many unknown blocks.

Thank you,

JC

[Krock]

Hello. Here's a few ideas to find out more information about the crash.
1) Install an in-development daily build and check whether it still happens: https://code.launchpad.net/~minetestdev ... /+packages
2) Run minetest(server) using gdb in the terminal like this:

Code: Select all

gdb minetest
r
<wait for crash>
bt
<crash dump appears here>


[JCB]

Thank you, so far so good.... running 5.1 Dev. The issue was reproducible when entering any new unexplored area. So far so good with the Dev

JC

[JCB]

Hello,

Just had a crash,
Below is the output:

Starting program: /usr/bin/minetest
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff7fb2700 (LWP 7875)]
[Thread 0x7ffff7fb2700 (LWP 7875) exited]
[New Thread 0x7fffe68ca700 (LWP 7876)]
[Thread 0x7fffe68ca700 (LWP 7876) exited]
[New Thread 0x7fffe68ca700 (LWP 7877)]
[New Thread 0x7fffd60c9700 (LWP 7878)]
[New Thread 0x7fffd4ea7700 (LWP 7879)]
[New Thread 0x7fffcd672700 (LWP 7880)]
[New Thread 0x7fffcce71700 (LWP 7881)]
[New Thread 0x7fffbffff700 (LWP 7882)]
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_1 (#1: Base ground height) noise_params -10, 50, (1024,1024,1024), 5202, 6, 0.4, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_2 (#2: Valleys) noise_params 0, 1, (256,256,256), -6050, 5, 0.6, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_3 (#3: Valleys depth) noise_params 5, 4, (512,512,512), -1914, 1, 1, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_4 (#4: Valleys profile) noise_params 0.6, 0.5, (512,512,512), 777, 1, 1, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_5 (#5: Inter-valleys slopes) noise_params 0.5, 0.5, (128,128,128), 746, 1, 1, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_6 (#6: Inter-valleys filling) noise_params 0, 1, (256,512,256), 1993, 6, 0.8, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_8 (#8: Caves I) noise_params 0, 1, (32,32,32), -4640, 4, 0.5, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_9 (#9: Caves II) noise_params 0, 1, (32,32,32), 8804, 4, 0.5, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_10 (#10: Caves III) noise_params 0, 1, (32,32,32), -4780, 4, 0.5, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_11 (#11: Caves IV and Lava) noise_params 0, 1, (32,32,32), -9969, 4, 0.5, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_12 (#12: Geological heat) noise_params 0, 1, (64,64,64), 3314, 4, 0.5, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_7 (#7: Dirt thickness) noise_params 4, 1.75, (256,256,256), 1605, 3, 0.5, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_13 (#13: Clay) noise_params 0, 1, (256,256,256), 2835, 5, 0.5, 4"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_14 (#14: Silt) noise_params 0, 1, (256,256,256), 6674, 5, 0.5, 4"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_15 (#15: Sand) noise_params 0, 1, (256,256,256), 6940, 5, 0.5, 4"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_16 (#16: Beaches) noise_params 2, 8, (256,256,256), 2349, 3, 0.5, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_17 (#17: Temperature) noise_params 0, 1, (768,256,768), -1805, 4, 0.5, 4"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_18 (#18: Humidity) noise_params 0, 1, (243,243,243), -5787, 4, 0.5, 3"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_19 (#19: Simple caves I) noise_params 0, 1, (64,64,64), -8402, 3, 0.5, 2"
2019-03-31 16:19:27: ERROR[Main]: Invalid setting type "noise_params" in /home/jc/.minetest/mods/valleys_mapgen/settingtypes.txt "vmg_noise_20 (#20: Simple caves II) noise_params 0, 1, (64,64,64), 3944, 3, 0.5, 2"
Loaded texture: /usr/share/minetest/games/minetest_game/menu/header.png
Loaded texture: /usr/share/minetest/games/minetest_game/menu/icon.png
Loaded texture: /usr/share/minetest/games/minimal/menu/icon.png
[Thread 0x7fffbffff700 (LWP 7882) exited]
[Thread 0x7fffcce71700 (LWP 7881) exited]
[Thread 0x7fffcd672700 (LWP 7880) exited]
[Thread 0x7fffd4ea7700 (LWP 7879) exited]
[New Thread 0x7fffbffff700 (LWP 7920)]
[New Thread 0x7fffcce71700 (LWP 7921)]
2019-03-31 16:19:30: WARNING[Main]: Mod name conflict detected: "farming"
2019-03-31 16:19:30: WARNING[Main]: Will not load: /usr/share/minetest/games/minetest_game/mods/farming
2019-03-31 16:19:30: WARNING[Main]: Overridden by: /home/jc/.minetest/mods/farming
2019-03-31 16:19:30: WARNING[Main]: Mod name conflict detected: "stairs"
2019-03-31 16:19:30: WARNING[Main]: Will not load: /usr/share/minetest/games/minetest_game/mods/stairs
2019-03-31 16:19:30: WARNING[Main]: Overridden by: /home/jc/.minetest/mods/stairs
[OK] Mesecons
Pipeworks loaded!
[MOD] Stairs Redo loaded
2019-03-31 16:19:30: WARNING[Main]: WARNING: minetest.setting_* functions are deprecated. Use methods on the minetest.settings object. (at /home/jc/.minetest/mods/valleys_mapgen/init.lua:6)
2019-03-31 16:19:30: WARNING[Main]: get_mapgen_params is deprecated; use get_mapgen_setting instead (at /home/jc/.minetest/mods/valleys_mapgen/init.lua:13)
2019-03-31 16:19:30: WARNING[Main]: get_mapgen_params is deprecated; use get_mapgen_setting instead (at /home/jc/.minetest/mods/valleys_mapgen/init.lua:24)
2019-03-31 16:19:30: WARNING[Main]: set_mapgen_params is deprecated; use set_mapgen_setting instead (at /usr/share/minetest/builtin/game/register.lua:603)
2019-03-31 16:19:30: WARNING[Main]: Field "noise_threshhold": Deprecated: new name is "noise_threshold".
2019-03-31 16:19:30: WARNING[Main]: Field "noise_threshhold": Deprecated: new name is "noise_threshold".
2019-03-31 16:19:30: WARNING[Main]: WARNING: minetest.setting_* functions are deprecated. Use methods on the minetest.settings object. (at /home/jc/.minetest/mods/unified_inventory/init.lua:47)
2019-03-31 16:19:30: WARNING[Main]: WARNING: minetest.setting_* functions are deprecated. Use methods on the minetest.settings object. (at /home/jc/.minetest/mods/unified_inventory/init.lua:50)
2019-03-31 16:19:30: WARNING[Main]: WARNING: minetest.setting_* functions are deprecated. Use methods on the minetest.settings object. (at /home/jc/.minetest/mods/unified_inventory/init.lua:83)
[UnifiedDyes] Loaded!
2019-03-31 16:19:30: WARNING[Main]: No craft recipe matches input
2019-03-31 16:19:30: WARNING[Main]: No craft recipe matches input
2019-03-31 16:19:30: WARNING[Main]: No craft recipe matches input
2019-03-31 16:19:30: WARNING[Main]: No craft recipe matches input
2019-03-31 16:19:30: WARNING[Main]: No craft recipe matches input
2019-03-31 16:19:30: WARNING[Main]: No craft recipe matches input
2019-03-31 16:19:30: WARNING[Main]: No craft recipe matches input
2019-03-31 16:19:31: WARNING[Main]: Not registering alias, item with same name is already defined: homedecor:armchair -> homedecor:armchair_black
[New Thread 0x7fffcd672700 (LWP 7922)]
.__ __ __
_____ |__| ____ _____/ |_ ____ _______/ |_
/ \| |/ \_/ __ \ __\/ __ \ / ___/\ __\
| Y Y \ | | \ ___/| | \ ___/ \___ \ | |
|__|_| /__|___| /\___ >__| \___ >____ > |__|
\/ \/ \/ \/ \/
2019-03-31 16:19:31: ACTION[Main]: World at [/home/jc/.minetest/worlds/New World]
2019-03-31 16:19:31: ACTION[Main]: Server for gameid="minetest" listening on 0.0.0.0:30001.
[New Thread 0x7fffd4ea7700 (LWP 7923)]
[New Thread 0x7fffbf3fe700 (LWP 7924)]
[New Thread 0x7fffbd2e5700 (LWP 7925)]
Unified Inventory. inventory size: 1510
2019-03-31 16:19:31: WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: Interlace handling should be turned on when using png_read_image
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: Interlace handling should be turned on when using png_read_image
2019-03-31 16:19:32: WARNING[Main]: Irrlicht: PNG warning: Interlace handling should be turned on when using png_read_image
2019-03-31 16:19:33: WARNING[Main]: TextureSource::getPalette(): the specified palette image "unifieddyes_palette_extended.png" is larger than 256 pixels, using the first 256.
[New Thread 0x7fffaed16700 (LWP 7939)]
2019-03-31 16:19:34: ACTION[Server]: Host [127.0.0.1] joins game.
2019-03-31 16:19:34: ACTION[Server]: Host joins game. List of players: Host
2019-03-31 16:19:35: WARNING[Main]: Client side scripting is disabled by client.
[New Thread 0x7fffae515700 (LWP 7941)]

Thread 17 "Emerge-0" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffae515700 (LWP 7941)]
0x00005555558b27f4 in ModApiBase::l_deprecated_function(lua_State*) ()
(gdb)


I hope that this helps, I see that there is the Client side scripting message again followed by a Seg fault

Thank you

JCB

[paramat]

Do you have 'deprecated_lua_api_handling = error' in minetest.conf?

After typing 'bt', also type 'bt full' for more backtrace.

Also contact the mod author, the mod needs updating in many ways.

[duane]

It would help if you'd post your minetest.conf and ~/.minetest/mods/valleys_mapgen/settingtypes.txt files. It looks at first glance as though you're using an old settingtypes.txt file. You'll want to get the latest version of valleys from github to correct some of those errors. The segfault is probably a different issue, so you might want to back up your current valleys, if you want to troubleshoot it further.

[Wuzzy]

The valleys_mapgen mod is deprecated for over 3 years. Stop using it. Use the core mapgen called “valleys” instead.

[JCB]

Thank you for pointing out that it is now built in. There are some advantages.

JC

[paramat]

Yes the core mapgen 'Valleys' is derived from and similar to the lua version, not identical, but there are many advantages to using the C++ version.

[ShadMOrdre]

Lua Valleys mapgen was recently updated by the mod author. The newest version includes a newer 3D noise param to carve the valleys, IIRC, and by reading the last post from the author, should also be 5.0 compatible. I would strongly urge to update to latest git version of the Lua Valleys mapgen, as I have yet to encounter any issues with it and my mod heavy setup.

For general usage, the built in mg_valleys is by far better. IMHO, there is still much value in the lua version, as both a code example, and, for the not so faint of heart, as a code base for modding. The "also outdated" valleys_c mod, used portions of the lua valleys voxel.lua, and was a huge inspiration for my own lib_ecology/lib_materials mods.

[paramat]

The new 3D river valleys feature has been opened as a PR and will probably be added to the core mapgen.